Support kls scheme for kotlin-language-server #4051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yyoncho
reviewed
May 14, 2023
|
Can you resolve the conflicts? |
|
@aiguofer , any chance to fix the conflicts here? Think your PR looks exciting, and I think it would be really cool to get it merged so more people can try it. Sorry for posting in an older PR, just thought it seemed really cool 🙂 |
|
@themkat sorry for the delay! updated |
yyoncho
approved these changes
Dec 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a custom
klsscheme is returned by the server, parse the returned string to find the path to the container file (jar/zip/etc) and the path to the file within it that contains the code def. Make another call to the server usingkotlin/jarClassContentsto get the contents for the file, and save a cached copy in thelsp-kotlin-workspace-dirusing the name and dir of the container file (concatenated with a.) as the cache dir name and the class file/package as the cache file name.Open Question:
with-lsp-workspaceonly works for Java dependencies if I don't havelsp-javaenabled. When I enable that, it starts up alsp-javaserver when I go to a definition in a Java file. How can I configure it to not start a java lsp server when I navigate to a java definition fromkotlin-language-server?