Use variable watcher with lsp-defcustom to support local variables. #4349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When custom variables are set locally using `hack-local-variables`, a custom variable's registered setter is not invoked. To address this, a variable watcher is used instead to cause the setter to be invoked when the variable is updated.
|
Ping @yyoncho |
|
@yyoncho or @jcs090218, is there any reason this can't be merged? This causes problems for Ada when trying to specify the project file in a directory local variable as described in the linked issue. |
yyoncho
approved these changes
May 12, 2024
|
@jcs090218, can you merge this PR? This was reviewed/approved a while ago by @yyoncho, but never merged. |
|
Sorry, I was a little busy. 😓 Glad Ivan has already merged this! 🚀 |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When custom variables are set locally using
hack-local-variables, a custom variable's registered setter is not invoked. To address this, a variable watcher is used instead to cause the setter to be invoked when the variable is updated.Fixes #4337.