[feat] New customizations: helm-swoop-flash-region-function
#146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cireu
force-pushed
the
orp/custom-highlight-fn
branch
from
b20b5e6
to
668b1ef
Compare
|
LGTM. |
conao3
requested changes
Aug 13, 2019
helm-swoop.el
Outdated
| @@ -524,7 +535,7 @@ If $linum is number, lines are separated by $linum" | |||
| (when (or (and (and (featurep 'migemo) helm-migemo-mode) | |||
| (migemo-forward $regex nil t)) | |||
| (re-search-forward $regex nil t)) | |||
| (helm-swoop-flash-word (match-beginning 0) (match-end 0)) | |||
| (helm-swoop-do-flash-region (match-beginning 0) (match-end 0)) | |||
There was a problem hiding this comment.
(funcall helm-swoop-flash-region-function (match-beginning 0) (match-end 0))
instead of define helm-swoop-do-flash-region?
There was a problem hiding this comment.
Why not a small util function? At least it looks meaningful than direct calling funcall.
There was a problem hiding this comment.
Increasing small utility functions requires a lot of consideration.
For example, all functions declared with defsubst seem to be prefixed with helm-swoop--, but how about renaming them?
And In many cases, I think do is unnecessary.
cireu
force-pushed
the
orp/custom-highlight-fn
branch
from
668b1ef
to
f80b776
Compare
cireu
force-pushed
the
orp/custom-highlight-fn
branch
from
f80b776
to
26a3c2c
Compare
|
@conao3 OK now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.