#156266036 Reply Review #94
Conversation
[Start: #156266036]
[#156266036]
[#156266036]
[#156266036]
[#156266036]
…feature/156266036/reply-review
[#156266036]
| @@ -1,5 +1,5 @@ | |||
| import { Users, Recipes } from '../../models'; | |||
| import { setStatus, notFoundDispatcher } from '../../middleware/helper'; | |||
| import { setStatus } from '../../middleware/helper'; | |||
There was a problem hiding this comment.
Unable to resolve path to module '../../middleware/helper' import/no-unresolved
Missing file extension for "../../middleware/helper" import/extensions
| @@ -6,7 +6,7 @@ import { | |||
| serverErrorDispatcher | |||
| } from '../middleware/helper'; | |||
| import { postReview, fetchReview, deleteReviewEntry } from '../services/review'; | |||
| import { Recipes, Reviews, Users } from '../models'; | |||
| import { Recipes, Reviews, Users, ReviewsReply } from '../models'; | |||
There was a problem hiding this comment.
Unable to resolve path to module '../models' import/no-unresolved
Missing file extension for "../models" import/extensions
|
|
||
| // .reply-wrapper { | ||
| // background: |
There was a problem hiding this comment.
Files should end with a trailing newline
| } | ||
|
|
||
| // .reply-wrapper { |
| color: rgba(0, 0, 0, 0.411); // top: 1rem; | ||
| z-index: 2; | ||
| font-size: 1rem; |
There was a problem hiding this comment.
Property color already defined on line 1104
Color darkgray should be written in hexadecimal form as #a9a9a9
Color literals like darkgray should only be used in variable declarations; they should be referred to via variable everywhere else.
| @@ -29,6 +29,11 @@ export default ( | |||
| ...state, | |||
| delete_reviews: action.payload | |||
| }; | |||
| case type.GET_REPLIES: | |||
| return { | |||
| ...state, | |||
There was a problem hiding this comment.
Expected indentation of 8 spaces but found 6 indent
| @@ -29,6 +29,11 @@ export default ( | |||
| ...state, | |||
| delete_reviews: action.payload | |||
| }; | |||
| case type.GET_REPLIES: | |||
| return { | |||
There was a problem hiding this comment.
Expected indentation of 6 spaces but found 4 indent
| @@ -29,6 +29,11 @@ export default ( | |||
| ...state, | |||
| delete_reviews: action.payload | |||
| }; | |||
| case type.GET_REPLIES: | |||
There was a problem hiding this comment.
Expected indentation of 4 spaces but found 2 indent
| <div className="container reply-container"> | ||
| {showForm && ( | ||
| <form | ||
| onSubmit={event => { |
There was a problem hiding this comment.
Expected parentheses around arrow function argument having a body with curly braces arrow-parens
| )} | ||
| {!showReply && | ||
| comment.reviewsreply.length + increment === 0 && ( | ||
| <a> No reply </a> |
There was a problem hiding this comment.
The href attribute is required on an anchor. Provide a valid, navigable address as the href value jsx-a11y/anchor-is-valid
What does this PR do?
Enable a review to have a reply
Description of Task to be completed?
A user should be able to reply a review of another user
How should this be manually tested?
N/A
Any background context you want to provide?
N/A
What are the relevant pivotal tracker stories?
story type: feature
story Id: 156266036
story title: Reply Review
Screenshots (if appropriate)
Questions:
N/A