Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

web3 should not be initialized inside lib modules #34

Closed
nmushegian opened this issue Jul 10, 2015 · 1 comment
Closed

web3 should not be initialized inside lib modules #34

nmushegian opened this issue Jul 10, 2015 · 1 comment

Comments

@nmushegian
Copy link

If we want modules in lib/ to be reusable and composable, they can't each set their own web3 provider.
They should accept an initalized web3. Actually, we need a web3 wrapper which is lazily and intelligently initialized, acts as a mock, etc, uses promises, etc.

@nmushegian
Copy link
Author

nevermind, I misread where you were setting web3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant