Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert to promises or something async #39

Closed
linagee opened this issue Jul 24, 2015 · 1 comment
Closed

Convert to promises or something async #39

linagee opened this issue Jul 24, 2015 · 1 comment

Comments

@linagee
Copy link
Contributor

linagee commented Jul 24, 2015

It doesn't work for me. I'm running Ubuntu 14.10, embark 0.7.0, geth 0.9.39
This seems like a really bad way to implement it (but then, I was told it was a hack, so, eh..)

lib/deploy.js

      while ((receipt = web3.eth.getTransactionReceipt(transactionHash)) === null) {
          sleep.sleep(1);
      }

Sometimes I get "CONNECTION ERROR" (and sometimes it just quietly returned back to my shell without doing anything), I think web3 just trying over and over again to do JSON-RPC to geth. I tried to convert this into a way to use the callbacks on the .new() call to a contract that tell you the address, but then everything else broke. (Such as when it goes to write the ABI, it wasn't waiting for the transaction to finish being deployed, it was depending on this loop to repeat.)

I'm not sure what the best way to fix all of this is, unfortunately I'm not a JS expert. :-(

Good luck converting it to promises/async stuff.

@linagee
Copy link
Contributor Author

linagee commented Jul 24, 2015

Repeat of #30
I'll just put my request over there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant