Update Rust nightly. #729
Merged
Update Rust nightly. #729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
WIP, investigating why it now fails in older nightlies...??? |
Fixes a new opaque type error in the task macro. Full error is "opaque type's hidden type cannot be another opaque type from the same scope". This got disallwed by the lazy-TAIT PR: rust-lang/rust#94081 Sadly there's now some weird type inference errors with pre-lazy-TAIT nightlies, so support for those is dropped.
Dirbaio
changed the title
|
it seems a type inference bug in pre-lazy-tait Rust. Can be fixed with yet another wrapper fn, but I'd rather not do it because it's more opportunities for the optimizer to fail to inline stuff. Let's drop support for old nightlies instead. |
bors bot
added a commit
that referenced
this pull request
Apr 26, 2022
732: macros: simplify task macro using "TAIT laundering". r=Dirbaio a=Dirbaio This brings the macro to the state before the nightly update #729 #730, with a much cleaner workaround for the opaque type error, from rust-lang/rust#96406 Co-authored-by: Dario Nieuwenhuis <dirbaio@dirbaio.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a new opaque type error in the task macro.
Full error is "opaque type's hidden type cannot be another opaque type from the same scope".
This got disallwed by the lazy-TAIT PR: rust-lang/rust#94081
Sadly there's now some weird type inference errors with pre-lazy-TAIT
nightlies, so support for those is dropped.