Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump minimum e-g version to 0.7.1 #34

Merged
merged 2 commits into from
Jun 15, 2021
Merged

Bump minimum e-g version to 0.7.1 #34

merged 2 commits into from
Jun 15, 2021

Conversation

jamwaffles
Copy link
Member

Thank you for helping out with embedded-graphics-simulator development! Please:

  • Check that you've added passing tests and documentation
  • Add an example where applicable
  • Add a CHANGELOG.md entry in the Unreleased section under the appropriate heading (Added, Fixed, etc) if your changes affect the public API
  • Run rustfmt on the project
  • Run just build (Linux/macOS only) and make sure it passes. If you use Windows, check that CI passes once you've opened the PR.

PR description

Supersedes #32

@jamwaffles jamwaffles requested a review from rfuest June 15, 2021 16:15
Copy link
Member

@rfuest rfuest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rfuest
Copy link
Member

rfuest commented Jun 15, 2021

I haven't thoroughly checked this, but tinytga and tinybmp might also need to be updated to e-g 0.7.1. At least DynamicTga and DynamicBmp use the From color conversions.

@jamwaffles jamwaffles mentioned this pull request Jun 15, 2021
@jamwaffles
Copy link
Member Author

Noted, I'll get some PRs ready for them too in that case. It can't hurt to be cautious even if it's not required.

@jamwaffles jamwaffles merged commit e6dcee8 into master Jun 15, 2021
@jamwaffles jamwaffles deleted the bump-eg branch June 15, 2021 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants