Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Indic xnli pair classification #581

Conversation

SaitejaUtpala
Copy link
Contributor

Checklist for adding MMTEB dataset

Reason for dataset addition:

  • I have tested that the dataset runs with the mteb package.
  • I have run the following models on the task (adding the results to the pr). These can be run using the mteb run -m {model_name} -t {task_name} command.
    • sentence-transformers/paraphrase-multilingual-MiniLM-L12-v2
    • intfloat/multilingual-e5-small
  • I have checked that the performance is neither trivial (both models gain close to perfect scores) nor random (both models gain close to random scores).
  • If the dataset is too big (e.g. >2048 examples), considering using self.stratified_subsampling() under dataset_transform()
  • I have filled out the metadata object in the dataset file (find documentation on it here).
  • Run tests locally to make sure nothing is broken using make test.
  • Run the formatter to format the code using make lint.
  • I have added points for my submission to the points folder using the PR number as the filename (e.g. 438.jsonl).

@SaitejaUtpala
Copy link
Contributor Author

waiting until #582

@imenelydiaker
Copy link
Contributor

imenelydiaker commented Apr 29, 2024

waiting until #582

This is not really an issue, @loicmagne already answered, you need to adjust your dataset to meet the expected format by the PC task. Please check existing examples fo PC tasks with data_transform() function that adjusts datasets to the expected format.

We'll think about updating this format but for now it's not the priority. Note that this update would require to update all mteb/*PC datasets.

Comment on lines +49 to +51
# removing this indic xnli is 3-way (entailment, neutral, )
# for label in labels:
# assert label == 0 or label == 1
Copy link
Contributor

@imenelydiaker imenelydiaker May 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Undo this change and filter out the neutral values just as it has been done here: XNLI

@KennethEnevoldsen
Copy link
Contributor

From the checklist it seems like this is still a work in progress. Will close it for now, but feel free to re-open it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants