Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add primecount test. #142

Merged
merged 1 commit into from
Aug 16, 2021
Merged

Add primecount test. #142

merged 1 commit into from
Aug 16, 2021

Conversation

PaoloS02
Copy link
Contributor

@PaoloS02 PaoloS02 commented Aug 2, 2021

The test primecount searches and counts the prime numbers up to a given limit.
This version of the test is a reduction of the test proposed by Bruce Hoult.
The limit has been reduced in order to fit the execution time on a Cortex M4
working at 16 MHz into 4 seconds.

Files changed:

* src/primecount/primecount.c: Created.
* baseline-data/size.json: Added the result for primecount.
* baseline-data/speed.json: Likewise.

Thanks to Bruce Hoult bruce@hoult.org for providing the test.

@Roger-Shepherd
Copy link
Contributor

This works when I add in to the tests I can run on M1 Mac. I'm not sure of the significance of the size/time numbers in the benchmark source. They don't seem to align with the figures I get for M1.

@PaoloS02
Copy link
Contributor Author

PaoloS02 commented Aug 16, 2021

Thanks @Roger-Shepherd
I guess you set the value of SZ as 1000 to check that, right?
It could make sense to remove the results in the comments or to comment as a "broad reference" as they were not obtained in the embench infrastructure. It would be pretty demanding to collect the binaries that achieve those numbers and compare in order to understand how the size measurement was made for those.
same for the execution time.

@Roger-Shepherd
Copy link
Contributor

Thanks @Roger-Shepherd
I guess you set the value of SZ as 1000 to check that, right?

No!

It could make sense to remove the results in the comments or to comment as a "broad reference" as they were not obtained in the embench infrastructure. It would be pretty demanding to collect the binaries that achieve those numbers and compare in order to understand how the size measurement was made for those.
same for the execution time.

Yes. Certainly something saying they aren't comparable because (i) SZ, (ii) methodology

@PaoloS02
Copy link
Contributor Author

I will clarify that in the comment then. Thanks for the update

The test primecount searches and counts the prime numbers up to a given limit.
This version of the test is a reduction of the test proposed by Bruce Hoult.
The limit has been reduced in order to fit the execution time on a Cortex M4
working at 16 MHz into 4 seconds.

Files changed:

	* src/primecount/primecount.c: Created.
	* baseline-data/size.json: Added the result for primecount.
	* baseline-data/speed.json: Likewise.

Thanks to Bruce Hoult <bruce@hoult.org> for providing the test.
@PaoloS02
Copy link
Contributor Author

I added a comment that clarifies this. Ready to merge.

@jeremybennett
Copy link
Collaborator

Good to merge.

@jeremybennett jeremybennett merged commit 4c4462e into embench:master Aug 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants