Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guard md5sum printf by DEBUG #175

Merged
merged 1 commit into from
Feb 20, 2023

Conversation

I-mikan-I
Copy link
Contributor

The md5sum benchmark included printf calls which were not guarded by any flag, meaning that the benchmark relied on stdout and requires any platform to support linking against a functional libc implementation.

With the added #DEBUG guard, none of the benchmarks perform I/O.

@jeremybennett
Copy link
Collaborator

Hi @I-mikan-I

Thanks for the patch. This benchmark is a work in progress as a candidate for release 2.0. Eventually we'll remove references to printf altogether, but this makes the benchmark immediately usable.

I have captured this action as issue #177

Looks good to merge.

@jeremybennett jeremybennett merged commit d9b30cd into embench:master Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants