Guard against key-less nodes. Fixes #71 #72
+1,888
−570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trentmwillis
reviewed
Jul 7, 2017
rwjblue
approved these changes
Jul 7, 2017
trentmwillis
requested changes
Jul 7, 2017
There was a problem hiding this comment.
@mwpastore do you think you can add a test or two for this? After that, we can land this!
|
@trentmwillis Hrrm, how can I add a babel plugin to a single RuleTester run unit? |
|
Good question, I don't know exactly. But, looking at the docs, looks like you can define it in the hash just like you would in the ESLint config.
|
mwpastore
force-pushed
the
fix-spread-nodes
branch
from
906e4da
to
bb3f96f
Compare
mwpastore
force-pushed
the
fix-spread-nodes
branch
from
bb3f96f
to
6d2320b
Compare
mwpastore
force-pushed
the
fix-spread-nodes
branch
from
6d2320b
to
11b7a3d
Compare
mwpastore
force-pushed
the
fix-spread-nodes
branch
2 times, most recently
from
aa4fd13
to
1ed014d
Compare
mwpastore
force-pushed
the
fix-spread-nodes
branch
2 times, most recently
from
0d2d592
to
9c42494
Compare
Also clean up the no-jquery-method explanation a tiny bit.
ember-best-practices#93) * Fixes require-ember-lifeline rule to scope it to only ember file types
* Add missing tests This adds two failing tests to highlight bugs and a passing but previously missing test. The missing test added is for calling `set` which was destructured from `import Ember from 'ember'` One failing test is to handle the case where `Ember.computed` is called from an import that isn't named `Ember`, eg ``` import E from 'ember'; E.computed() ``` Another failing test illustrates that ember import bindings are clobbered if followed by any other default import, as in: ``` import Ember from 'ember'; import AnythingElse from 'anywhere'; ``` * Clean up no-side-effect-cp rule. Fixes a number of the errors previously identified, as well as a few additional ones (tests added in this commit).
TypeError: Cannot read property 'getFilename' of undefined at isLintableFile (/node_modules/eslint-plugin-ember-best-practices/lib/rules/require-ember-lifeline.js:33:53) at MemberExpression (/node_modules/eslint-plugin-ember-best-practices/lib/rules/require-ember-lifeline.js:69:14) at listeners.(anonymous function).forEach.listener (/node_modules/eslint/lib/util/safe-emitter.js:47:58) at Array.forEach ()
mwpastore
force-pushed
the
fix-spread-nodes
branch
from
9c42494
to
0d29a19
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is very rough with no tests, intended mostly to further the discussion on #71 for now.