New Linter Rule - set() must return a value

[caseywatts]

having a linter rule for this would help prevent some bugs
(at least until the behavior changes to be what people expect)
emberjs/rfcs#79

[Turbo87]

@caseywatts can you provide some examples of good and bad code?

[caseywatts]

Sure! :)

Bad:

height: 100,
goldenRatioWidth: computed('height', {
  get() {
    return this.get('height') * 1.618;
  },
  set(_, value) {
    this.set('height', value / 1.618);
  }
})

Good

height: 100,
goldenRatioWidth: computed('height', {
  get() {
    return this.get('height') * 1.618;
  },
  set(_, value) {
    const newHeight = value / 1.618;
    this.set('height', newHeight);
    return newHeight;
  }
})

set() must have a return.

[Turbo87]

@caseywatts seems like a good idea to me. do you want to work on it?

[Turbo87]

oh, actually I just noticed what repository we're in. could you move the issue including the snippets to https://github.com/ember-cli/eslint-plugin-ember?

[caseywatts]

ahaha you're right @Turbo87 thanks for catching this - I'll move this over to there 👍

[caseywatts]

made this over at ember-cli/eslint-plugin-ember#247