Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added isHTMLSafe to the ember-string shims. #93

Closed
wants to merge 1 commit into from

Conversation

workmanw
Copy link

@workmanw workmanw commented Mar 5, 2017

So Ember.String.isHTMLSafe was added in Ember 2.8. I was tempted to include the ember-string-ishtmlsafe-polyfill as a dependency, however we've been following the pattern of ember-assign-polyfill and ember-getowner-polyfill and neither of them are deps here.

I think it's logical to say that a consumer of ember-cli-shims using < Ember-2.8 has to also include the ember-string-ishtmlsafe-polyfill for themselves.

@locks
Copy link
Contributor

locks commented Apr 22, 2017

Hey @workmanw, it is my understanding that the old shims are frozen and we intend to deprecate them as you can see in #92. I am closing this due to the previous reasoning.
From your description it sounds like you have a path forward? Ping on Slack if otherwise, I volunteer rwj ;)

@locks locks closed this Apr 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants