[WIP][BUGFIX] Not overwrite the custom css configuration

[dukex]

Today the defaults merge is overwrite the css outputPath configured always adding the app config.
This pull request fix #4948 and is related with adopted-ember-addons/ember-cli-sass#81

See the problem, given the follow config

var app = new EmberApp({
  outputPaths: {
    app: {
      css: {
        'theme-orange': '/assets/theme-orange.css',
        'theme-purple': '/assets/theme-purple.css'
      }
    }
  }
});

With this config today it's expected a app.css but the user explicitly overwrote the css config. In the other hand the guides teach the user put the app file when he is overwrite the css outputPath

var app = new EmberApp({
  outputPaths: {
    app: {
      css: {
        'app': '/assets/application-name.css',
        'themes/alpha': '/assets/themes/alpha.css'
      }
    }
  }
});

A alternative and easy fix is tell to users always have a app.css because the ember will always send to addon the outputPaths with app

ps: Maybe I need fix some acceptance tests

[stefanpenner]

this seems reasonable.

cc @chadhietala i believe your change to fix the options merging may be related, can you 👀

[chadhietala]

If we are supporting Node 0.12.0 this will not work due to Object.assign not being a thing.

[stefanpenner]

we also support node 0.10.x

[dukex]

Thanks @chadhietala, fixed

[homu]

☔ The latest upstream changes (presumably #5367) made this pull request unmergeable. Please resolve the merge conflicts.

[stefanpenner]

this needs a rebase:

@chadhietala can you take another look, assign now comes from lodash
@rwjblue r?

[chadhietala]

Seems good.

[dukex]

I need to check the tests failing.

[homu]

☔ The latest upstream changes (presumably #5379) made this pull request unmergeable. Please resolve the merge conflicts.

[rwjblue]

I do not believe that we have omit being required any more, I believe it should be omitBy and this sholdn't need to be changed...

[stefanpenner]

@dukex can you update based on the above feedback + rebase ?

[dukex]

@stefanpenner sure, I'll do it today

[rwjblue]

I am not seeing how this is any different that what we already have since _.isNull is actually the same code:

    function isNull(value) {
      return value === null;
    }

I'm also confused how the merging of vendorFiles is related to outputPaths.

[stefanpenner]

@dukex ping

[Turbo87]

closing due to inactivity