Remove Travis allowed failures. #5463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original issue with both of these (npm 3.3.10 - 3.3.12 was the default and is completely busted) is no longer an issue (now that "5" resolves to 5.6.0).
rwjblue
force-pushed
the
remove-allowed-failures
branch
2 times, most recently
from
57573c3
to
e8fb1eb
Compare
1 task
An earlier version of broccoli-clean-css allowed the minification to escape the provided node, that has been corrected so our `relativeTo` here needs to change from allowing raw access to `app/styles` to accessing these CSS files from `assets` (which is where they are in the broccoli node provided during minification).
rwjblue
force-pushed
the
remove-allowed-failures
branch
from
e8fb1eb
to
a9f5954
Compare
The release of v4.3.0 as an LTS made our prior assumption that v4.2.x was the LTS incorrect (oddly). This change unlocks us to test whatever the current v4.x.x LTS in CI. See https://github.com/nodejs/node/blob/v4.3.0/CHANGELOG.md.
rwjblue
added a commit
that referenced
this pull request
Feb 14, 2016
Remove Travis allowed failures.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original issue with both of these (npm 3.3.10 - 3.3.12 was the default and is completely busted) is no longer an issue (now that "5" resolves to 5.6.0).
There are two remaining failures, both of which will be fixed by ember-cli/ember-cli-preprocess-registry#6.