Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a way to not use the source directory for relativeTo #12

Closed
XrXr opened this issue Dec 10, 2015 · 2 comments
Closed

Provide a way to not use the source directory for relativeTo #12

XrXr opened this issue Dec 10, 2015 · 2 comments

Comments

@XrXr
Copy link

XrXr commented Dec 10, 2015

@shinnn In old versions of broccoli-clean-css relativeTo can be set to anything. However in newer versions it is always relative to the source directory.

Libraries that use the old behaviour are blocked from upgrading because of this (ember-cli/ember-cli-preprocess-registry#6)

Can we get some way to bypass this forced rebasing?

@XrXr XrXr changed the title Provide a way to not use the source tree for relativeTo Provide a way to not use the source directory for relativeTo Dec 10, 2015
@rwjblue
Copy link

rwjblue commented Feb 14, 2016

I believe that the behavior of relativeTo in broccoli-clean-css is correct even though it was a breaking change to ember-cli (which was absolutely fine to do in a major version bump). See my detailed explanation in ember-cli/ember-cli-preprocess-registry#6 (comment).

ember-cli is being updated to use the correct value for relativeTo in ember-cli/ember-cli#5463.

@XrXr
Copy link
Author

XrXr commented Feb 14, 2016

Cool! There is no problem then.

@XrXr XrXr closed this as completed Feb 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants