Make "testdouble" dependency optional in MockProcess class #7395
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems like
mock-process
caused some inconveniences due to itstestdouble
dependency.Actually we need
testdouble
only inwill-interrupt-process
unit tesst. We have nothing to do withtestdouble
in any other scenarios.Also previously I thought it was a good idea to implement
MockProcess.exit()
as atestdouble.function()
. Unfortunately it wasn't. This approach isn't able to replicate a realprocess.exit()
behavior and leads to dishonest tests when we test cli/cli for example.That is the reason why I changed
MockProcess.exit()
to throw an exception.Known packages who was forced to install
testdouble
due to ember-cli@2.16 upgrade: