Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make "testdouble" dependency optional in MockProcess class #7395

Merged
merged 1 commit into from
Oct 21, 2017

Conversation

ro0gr
Copy link
Contributor

@ro0gr ro0gr commented Oct 19, 2017

Seems like mock-process caused some inconveniences due to its testdouble dependency.

Actually we need testdouble only in will-interrupt-process unit tesst. We have nothing to do with testdouble in any other scenarios.

Also previously I thought it was a good idea to implement MockProcess.exit() as a testdouble.function(). Unfortunately it wasn't. This approach isn't able to replicate a real process.exit() behavior and leads to dishonest tests when we test cli/cli for example.
That is the reason why I changed MockProcess.exit() to throw an exception.

Known packages who was forced to install testdouble due to ember-cli@2.16 upgrade:

@Turbo87 Turbo87 changed the title use testdouble explicitly Make "testdouble" dependency optional in MockProcess class Oct 21, 2017
@Turbo87 Turbo87 merged commit 6f3dd90 into ember-cli:master Oct 21, 2017
@Turbo87
Copy link
Member

Turbo87 commented Oct 21, 2017

thanks @ro0gr!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants