further unify all our *ignore files #7904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kellyselden
force-pushed
the
npmignore
branch
2 times, most recently
from
17b4e31
to
d2c6970
Compare
Turbo87
requested changes
Jul 19, 2018
blueprints/addon/files/npmignore
Outdated
| package.json.ember-try | ||
| /.node_modules.ember-try/ | ||
| /bower.json.ember-try/ | ||
| /package.json.ember-try/ |
There was a problem hiding this comment.
those two are not folders so they should not end with /
blueprints/app/files/.eslintignore
Outdated
| @@ -14,3 +14,5 @@ | |||
|
|
|||
| # ember-try | |||
| /.node_modules.ember-try/ | |||
| /bower.json.ember-try/ | |||
| /package.json.ember-try/ | |||
Turbo87
approved these changes
Jul 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I removed code from tests/fixtures/module-unification-addon. No sense keeping in sync when they are untested. #7903