Fix "no-global-jquery"

lib/rules/no-global-jquery.js

@@ -32,7 +32,7 @@ module.exports = {
 
       VariableDeclarator(node) {
         if (emberImportAliasName) {
-          if (utils.isMemberExpression(node.init)) {
+          if (node.init && utils.isMemberExpression(node.init)) {
             // assignment of type const $ = Ember.$;
             destructuredAssignment = node.id.name;
           } else {

lib/utils/utils.js

@@ -8,6 +8,7 @@ module.exports = {
   isMemberExpression,
   isCallExpression,
   isObjectExpression,
+  isObjectPattern,
   isArrayExpression,
   isFunctionExpression,
   isArrowFunctionExpression,
@@ -103,6 +104,16 @@ function isObjectExpression(node) {
   return node !== undefined && node.type === 'ObjectExpression';
 }
 
+/**
+ * Check whether or not a node is an ObjectPattern.
+ *
+ * @param {Object} node The node to check.
+ * @returns {boolean} Whether or not the node is an ObjectPattern.
+ */
+function isObjectPattern(node) {
+  return node !== undefined && node.type === 'ObjectPattern';
+}
+
 /**
  * Check whether or not a node is an ArrayExpression.
  *
@@ -333,12 +344,15 @@ function getPropertyValue(node, path) {
  * @return {Array}              list of object pattern bindings
  */
 function collectObjectPatternBindings(node, initialObjToBinding) {
+  if (!isObjectPattern(node.id)) return [];
+
   const identifiers = Object.keys(initialObjToBinding);
   const objBindingName = node.init.name;
   const bindingIndex = identifiers.indexOf(objBindingName);
   if (bindingIndex === -1) return [];
 
   const binding = identifiers[bindingIndex];
+
   return node.id.properties
     .filter(props => initialObjToBinding[binding].indexOf(props.key.name) > -1)
     .map(props => props.value.name);

tests/lib/rules/no-global-jquery.js

@@ -21,6 +21,36 @@ const MESSAGE = rule.meta.message;
 
 ruleTester.run('no-global-jquery', rule, {
   valid: [
+    {
+      code: `
+        import Ember from 'ember';
+
+        let something;
+
+        export default Ember.Component({
+          actions: {
+            valid() {
+              something = Ember.$('.invalid1');
+            }
+          }
+        });`,
+      parserOptions,
+    },
+    {
+      code: `
+        import Ember from 'ember';
+
+        const Em = Ember;
+
+        export default Ember.Component({
+          actions: {
+            valid() {
+              this.inv1 = Em.$('.invalid1');
+            }
+          }
+        });`,
+      parserOptions,
+    },
     {
       code: `
         export default Ember.Component({