Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo in docs / closure-actions.md #35

Merged
merged 1 commit into from
Mar 2, 2017
Merged

Typo in docs / closure-actions.md #35

merged 1 commit into from
Mar 2, 2017

Conversation

nfc036
Copy link
Contributor

@nfc036 nfc036 commented Mar 2, 2017

Shouldn't this be this.attrs.boom() instead of this.attr.boom()!?

@nfc036
Update closure-actions.md
d332408 
Shouldn't this be this.attrs.boom() instead of this.attr.boom()!?
@michalsnik
Copy link
Member

Hey @nfc036 , attrs is correct. This is glimmer specific thing as you can see here https://github.com/tildeio/glimmer/blob/1759c16defc546b034b97e37141187652ed93859/packages/%40glimmer/runtime/lib/component/interfaces.ts#L87

@michalsnik michalsnik closed this Mar 2, 2017
@nfc036
Copy link
Contributor Author

nfc036 commented Mar 2, 2017 •
edited
Loading

So I would kindly suggest to merge this pull request to correct the typo in the docs.

@michalsnik
Copy link
Member

michalsnik commented Mar 2, 2017 •
edited
Loading

Ah, kill me. I misread it..

@michalsnik michalsnik reopened this Mar 2, 2017
@nfc036
Copy link
Contributor Author

nfc036 commented Mar 2, 2017

;-)

@michalsnik michalsnik merged commit aded0b4 into ember-cli:master Mar 2, 2017
@michalsnik
Copy link
Member

Thanks @nfc036 and sorry for the confusion.

@nfc036 nfc036 deleted the patch-1 branch March 2, 2017 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalsnik michalsnik michalsnik approved these changes

Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nfc036 @michalsnik @Turbo87