Chore / Update plugin environment #4
Conversation
michalsnik
commented
Jan 16, 2017
michalsnik
commented
- Remove gulp
- Replace CircleCI with TravisCI
- Use yarn
michalsnik
force-pushed
the
update-repo
branch
from
d1369f0
to
ab51dee
Compare
michalsnik
force-pushed
the
update-repo
branch
from
ff2b1eb
to
4595461
Compare
| "test": "gulp test", | ||
| "start": "gulp watch" | ||
| "test": "./node_modules/.bin/mocha test/*", | ||
| "start": "./node_modules/.bin/mocha test/* --reporter nyan --watch" |
There was a problem hiding this comment.
It's not necessary to provide full path in NPM scripts - just mocha command here will resolve to node_modules/.bin/mocha, anyway.
| language: node_js | ||
| sudo: false | ||
| node_js: | ||
| - '6.3' |
| node_js: | ||
| - '6.3' | ||
|
|
||
| cache: yarn |
There was a problem hiding this comment.
Nice that TravisCI takes care of so much with Yarn automagically 🎊
There was a problem hiding this comment.
Yeah, I was surprised :)
| @@ -8,8 +8,8 @@ | |||
| "test": "test" | |||
| }, | |||
| "scripts": { | |||
| "test": "gulp test", | |||
| "start": "gulp watch" | |||
| "test": "./node_modules/.bin/mocha test/*", | |||
There was a problem hiding this comment.
Missing --reporter nyan - clear regression compared to current test command (https://github.com/netguru/eslint-plugin-ember/pull/4/files#diff-b9e12334e9eafd8341a6107dd98510c9L29).
There was a problem hiding this comment.
Hehe, let's keep CI serious and leave nyan on dev only ;)
There was a problem hiding this comment.
That's quite another question and topic to discuss - test command can and will be used in development and not only on CI, that's for sure. I'd just leave it the way it was (i.e. nyan reporter when running yarn test) to avoid PR noise, as removing nyancat seems out of its scope here - WDYT?
There was a problem hiding this comment.
Well, it's not a big deal but regarding the fact that running npm test in developement is a common scenario - it makes sense to keep it clean and simple as it was earlier 👍
