Match yeoman generator structure #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unrelated, but just wanted to say 👍 for removing the Gulp pre-processing; the coverage report was nice, but removing it makes it much easier to write new tests because you can just run the one test alone through Mocha. |
michalsnik
approved these changes
Jan 26, 2017
There was a problem hiding this comment.
Good job @alexlafroscia ! Everything looks perfect 👍 One more approval and we're good to 🚀
cc @kevinkucharczyk @jbandura
| @@ -8,8 +8,8 @@ | |||
| "test": "test" | |||
| }, | |||
| "scripts": { | |||
| "test": "mocha test/* --reporter nyan", | |||
| "start": "mocha test/* --reporter nyan --watch" | |||
| "test": "mocha tests --recursive --reporter nyan", | |||
There was a problem hiding this comment.
Grabbed it from the plugin config that would be generated, if you used Yeoman to create the initial plugin:
| var rules = {}; | ||
| var ruleDir = resolve(__dirname, 'rules'); | ||
|
|
||
| fs.readdirSync(ruleDir).forEach(function(name) { |
There was a problem hiding this comment.
Great that we can finally get rid of this 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5
Hope you don't mind I added myself to the contributors list.
At some point, someone should go through the files in
docs/rules/*and update them to be closer to the syntax of official docs files. My pass here just copies the contents from the one big file and breaks it up into individual ones.