[WIP] Update Ember Times template header size #267
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah this actually doesn't work, apologies
I think we can do this in HTML though. Can try that. I need to take a look at the Goodbits scraper stuff to make sure that this change won't break that. |
amyrlam
changed the title
|
issue addressed with #284, thanks @jessica-jordan |
|
the headers can be addressed as part of the move to empress, but ember times headers outside of the title no longer appear on the parent /blog route |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
WAS:
IS:
<h2>and<h3>Related Issue(s)
Manually update #261 and #266