adds missing italic font faces #340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pichfl, @mansona and I were working on these changes together but could not get it quite right. In Chrome, it appears as if the italics are being applied and then overruled by something (most likely the preload of the fonts). Interestingly, when we opened the project in Firefox we noticed that the variable fonts were being used and styles were being applied. Do you have thoughts as to how we might best fix this Chrome? |
- there are some missing italic and bold font faces as described in #335 - this adds the additional font faces and updates the version of existing font faces Co-Authored-By: Chris Manson <mansona@users.noreply.github.com>
jaredgalanis
force-pushed
the
adds-missing-italic-fonts
branch
from
e24a921
to
30fcf27
Compare
mansona
approved these changes
Sep 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-Authored-By: Chris Manson mansona@users.noreply.github.com