Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add alt attributes to images as appropriate #89

Closed
mansona opened this issue Oct 26, 2018 · 1 comment
Closed

Add alt attributes to images as appropriate #89

mansona opened this issue Oct 26, 2018 · 1 comment

Comments

@mansona
Copy link
Member

mansona commented Oct 26, 2018

We recently turned on template linting for this project but in an effort to get the PR merged we temporarily turned off the rule img-alt-attributes https://github.com/ember-learn/ember-website/blob/master/.template-lintrc.js#L6

We should turn that rule back on and add alt attributes to all images 👍
@mansona mansona mentioned this issue Oct 26, 2018
Closed
@abhilashlr abhilashlr mentioned this issue Oct 27, 2018
Closed
@MelSumner MelSumner changed the title Add alt attributes to all Images Add alt attributes to images as appropriate Nov 21, 2018
abhilashlr added a commit to abhilashlr/ember-website that referenced this issue Feb 22, 2019
@abhilashlr
[ember-learn#89]: Add alt attributes to images as appropriate
54a1813
locks added a commit that referenced this issue Feb 26, 2019
@locks
Merge pull request #180 from abhilashlr/img-alt-attributes
af061a6 
[#89]: Add alt attributes to images as appropriate
@MelSumner
Copy link
Member

We shipped this, so I'm closing the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mansona @MelSumner