Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tracking Branch for the Ember Website Redesign RFC #361

Merged
merged 237 commits into from
Feb 21, 2020
Merged

Tracking Branch for the Ember Website Redesign RFC #361

merged 237 commits into from
Feb 21, 2020

Conversation

mansona
Copy link
Member

@mansona mansona commented Jul 12, 2019

This PR is intended to track the progress of the Ember Website Redesign. This redesign has had an RFC process and the full content of the RFC can be seen here: https://emberjs.github.io/rfcs/0425-website-redesign.html

If you would like to follow this process take a look at the Website Redesign Github Project

@mansona mansona force-pushed the redesign-rfc branch 2 times, most recently from 7d55049 to 2e37d1e Compare August 8, 2019 08:32
ghislaineguerin and others added 15 commits August 8, 2019 10:41
@ghislaineguerin
add ember ecosystem page
32a689c
@ghislaineguerin
add image alt attributes
97e0061
@mansona
using the new grid implementation
c0ae66e
@mansona
Add ember ecosystem page (#376)
9d1990a 
Add ember ecosystem page
@balinterdi
Add main section (first pass)
b779268
@mansona
moving to one image for landing logos
08cb431
@mansona
removing unused "home" page implementations
0d04291
@mansona
fixing tests
7f7d373
@mansona
Merge pull request #380 from balinterdi/add-main-section
bbe3c16 
Add main section to new landing page (first pass)
@mansona
fixing percy variablity
63f9a3f
@balinterdi
Merge pull request #381 from ember-learn/fix-percy
9989dbd 
fixing percy variablity
@balinterdi
Add Batteries included section to new homepage
18bdc22
@mansona
Add Batteries included section to new homepage (#383)
5ec791e 
Add Batteries included section to new homepage
@balinterdi
First, rough impl. for Ready to start shipping section
7a0af0d
@balinterdi
Add images for blog and guides
de37aa7
Windvis and others added 2 commits February 20, 2020 15:21
@Windvis
remove the eq and gte helpers
6a8338b 
These are no longer needed due to the ember-truth-helpers equivalents
@MelSumner
Merge pull request #589 from Windvis/redesign/install-ember-truth-hel…
ebc7dfb 
…pers

Redesign/install ember truth helpers
@MelSumner MelSumner requested a review from a team February 20, 2020 15:48
Windvis and others added 15 commits February 20, 2020 16:25
@Windvis
make sure the AddonTabs button text doesn't shift when clicking
282c98a
@Windvis
give the AddonTabs buttons a solid border
418dafd 
This prevents the strange border styling when clicking the button
@Windvis
make the AddonTabs component fully keyboard accessible
cad5ee3
@Windvis
make sure the EmberConf CTA looks the same in all browsers
dece1d1
@MelSumner
Merge pull request #592 from Windvis/redesign/cta-layout-issue
1cee3da 
Fix EmberConf CTA layout issue
@MelSumner
Merge pull request #585 from Windvis/redesign/addon-tabs-keyboard-imp…
8038cb1 
…rovements

AddonTabs keyboard improvements
@MelSumner @mansona
update styles for ember-survey and add close btn
e8ffbee
@mansona
add 2020 survey page
50203b2
@mansona
add template for survey logo svg
33e85fd
@mansona
convert survey logos to svg
065ee5d
@mansona
enable 2020 survey
bc7a609
@mansona
fix the survey cta component tests
21fb378
@MelSumner
Merge pull request #591 from Windvis/redesign/addon-tabs-styling-impr…
96239c4 
…ovements

Redesign/addon tabs styling improvements
@MelSumner
Merge pull request #594 from ember-learn/cta-banner
9868456 
Ember 2020 Survey with banner
@mansona
Merge branch 'master' into redesign-rfc
77040fe
MelSumner
MelSumner previously approved these changes Feb 21, 2020
View reviewed changes
Copy link
Member

@MelSumner MelSumner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it! 👍 💯

@github-actions
Copy link

Files that got Bigger 🚨:

File raw gzip
auto-import-fastboot.js +375 kB +120 kB
ember-website.js +21.3 kB +7.18 kB
ember-website-fastboot.js +813 B +380 B

Files that got Smaller 🎉:

File raw gzip
vendor.js -1.4 MB -438 kB
ember-website.css -41.9 kB -10.2 kB
vendor.css -16.5 kB -9.36 kB

@mansona mansona changed the title [WIP] Tracking Branch for the Ember Website Redesign RFC Tracking Branch for the Ember Website Redesign RFC Feb 21, 2020
@github-actions
Copy link

Files that got Bigger 🚨:

File raw gzip
auto-import-fastboot.js +375 kB +120 kB
ember-website.js +21.3 kB +7.18 kB
ember-website-fastboot.js +813 B +380 B

Files that got Smaller 🎉:

File raw gzip
vendor.js -1.41 MB -438 kB
ember-website.css -41.9 kB -10.2 kB
vendor.css -16.2 kB -9.29 kB

MelSumner
MelSumner approved these changes Feb 21, 2020
View reviewed changes
Copy link
Member

@MelSumner MelSumner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YES!

@MelSumner MelSumner merged commit 4082ff3 into master Feb 21, 2020
@NullVoxPopuli
Copy link
Contributor

NullVoxPopuli commented Feb 21, 2020 •
edited
Loading

Omg. Yay 🎉

@jayjayjpg jayjayjpg mentioned this pull request Apr 25, 2020
Closed
@ijlee2 ijlee2 deleted the redesign-rfc branch October 16, 2020 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knownasilya knownasilya knownasilya left review comments

@MelSumner MelSumner MelSumner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.