-
-
Notifications
You must be signed in to change notification settings - Fork 497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Add Template Tag format guides #1978
Conversation
✅ Deploy Preview for ember-guides ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
One of the biggest teaching points I think we need to hit here is how to locate the components/helpers/modifiers you're trying to import. There are generally-applicable, simple rules that work for essentially all addons. For example, an addon allowing you to importi a component from |
Another gotcha to document: to use an imported template, it needs to not be using the old, pre-template-colocation format where the templates is in If you must use it, you can use setComponentTemplate manually to stick the template and JS together, but probably that is not guides-level content. |
Thanks @NullVoxPopuli @ef4 for the feedback. I did a full rewrite from scratch instead of starting from the Marked as ready for review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few typos, rest looks good to me
Co-authored-by: Lukas Nys <nyslukas@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The learning team did a review on this PR. These are minor changes but I think they should help get this perfectly ready to merge and launch 🎉 Let me know if you have any questions about my comments 👍
Co-authored-by: Chris Manson <mansona@users.noreply.github.com>
Co-authored-by: Chris Manson <mansona@users.noreply.github.com>
All comments should be addressed now, thanks for the great input! I've added another short section on importing conventions for helpers and modifiers. They change from kebab-case to camelCase as it now follows ES import standards. I've seen some confusion and questions on Discord about this so I believe this had to be addressed as well. |
This reverts commit 5ea8d3d.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 💪 🎉 🚀
While eventually all guide material will have to be updated to use the
<template>
tag authoring format, this PR serves as a first introduction to the format. This unblocks moving forward emberjs/rfcs#871.Notes:
glimmer-js
norglimmer-ts
. I don't think it should block introducing the concept of the format here. But it does seem like a blocker to integrate the format in other parts of the guides.Sources:
To review
Preview: https://deploy-preview-1978--ember-guides.netlify.app/release/components/template-tag-format/
Review for: