Grammatical fixes for "Contributing to Ember.js" #623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jason-maier
force-pushed
the
octane-contributing
branch
from
fd8576b
to
66ac432
Compare
|
Has a grammatical error in their commit message about fixing grammatical errors. 😆 |
jenweber
approved these changes
Mar 16, 2019
|
Thank you Jason! Did you review all sub-sections or this one page? I'll update the quest issue! |
|
Hi @jenweber I reviewed all of the subsections under contributing I didn't have any changes for the repositories page! |
|
Fantastic, thanks so much! |
lenoraporter
pushed a commit
to lenoraporter/guides-source
that referenced
this pull request
Jul 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributing
Minor changes for clarity and readability.
Repositories
Went through all links to make sure they were still accurate. No changes necessary here.
Part of Octane Guides review #588