resyncing guides source with what is currently live #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
25 tasks
locks
reviewed
Dec 22, 2017
guides/v2.15.0/tutorial/service.md
Outdated
| @@ -128,7 +128,7 @@ export default Ember.Service.extend({ | |||
| }, | |||
|
|
|||
| getMapElement(location) { | |||
| let camelizedLocation = Ember.String.camelize(location); | |||
| let camelizedLocation = location.camelize(); | |||
locks
reviewed
Dec 22, 2017
| @@ -125,7 +125,7 @@ test('should list available rentals.', function (assert) { | |||
|
|
|||
| Run the tests again using the command `ember t -s`, and toggle "Hide passed tests" to show your new passing test. | |||
|
|
|||
| Now we are listing rentals, and verifying it with an acceptance test. | |||
| Now we are listing rentals, and and verifying it with an acceptance test. | |||
|
@locks sorted those two now 👍 it's not a given that we should merge this btw, it's just closer to what is currently live on the guides site |
chancancode
pushed a commit
that referenced
this pull request
Aug 22, 2019
Merge pull request #7 from vaidehijoshi/creating-components Add chapter 5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates guides source to be in sync with the deployed v2.15.0 of the guides. We can choose if we would rather not sync because some of these changes are improvements 👍
I figured out the checkout that is currently deployed is: emberjs/guides@b77a302
Also, this removes some unnecessary changes we made while testing the new guides-app.
ember-learn/guides-app#4