Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.12.1 has the wrong /dev/ path for enumerate_dev_nodes_blocking #129

Closed
jtroo opened this issue Jun 19, 2023 · 7 comments
Closed

v0.12.1 has the wrong /dev/ path for enumerate_dev_nodes_blocking #129

jtroo opened this issue Jun 19, 2023 · 7 comments

Comments

@jtroo
Copy link
Contributor

jtroo commented Jun 19, 2023

Thanks for the work on this crate!

A user of my project discovered a bug in v0.12.1 where the dev node paths have changed since v0.12.0. It remains an iterator with a single entry as expected, but the single entry has an unexpected path.

jtroo/kanata#455

The symlink which Kanata creates for the virtual output device points at /sys/devices/virtual/input/input8/event1 which is a folder with a bunch of metadata rather than the expected /dev/input/event1.
The Created device /path/to/device message shows the same incorrect path.

@mattfbacon
Copy link

I traced this back to 50a3369. The commit message is not really correct because in addition to removing the loop and returning Ok(None) at the end it also changes the behavior by removing the path manipulation. I would open a PR but I think this repository is abandoned.

@jeff-hiner
Copy link
Collaborator

As far as I know the crate is still active. I'm still a reviewer and have merge perms, but I don't have permissions to publish. If you submit a PR I'll take a look.

@emberian
Copy link
Owner

emberian commented Jan 14, 2024

not quite abandoned, i'll merge and release any important PRs. i've recently resumed my open source work after long sabbatical, haven't gotten back to this crate yet

@mattfbacon
Copy link

Good to know

wolfwood added a commit to wolfwood/evdev that referenced this issue May 4, 2024
This reverts commit d0231e3.

resolves device pathname regression, issue emberian#129
wolfwood added a commit to wolfwood/evdev that referenced this issue May 4, 2024
This reverts commit d0231e3.

resolves device pathname regression, issue emberian#129
@wolfwood
Copy link
Contributor

wolfwood commented May 4, 2024

a bisect using kanata points to d0231e3 as the commit responsible. reverting this commit on top of 0.12.1 allows kanata to retain the previous behavior.

I've made PR #147 with the revert. Ideally though would be a 0.12.2 release that cherrypicks the revert on top of 0.12.1. I have a branch with that here: f17826f

coolreader18 pushed a commit that referenced this issue May 7, 2024
This reverts commit d0231e3.

resolves device pathname regression, issue #129
coolreader18 pushed a commit that referenced this issue May 8, 2024
This reverts commit d0231e3.

resolves device pathname regression, issue #129
@coolreader18
Copy link
Collaborator

Released 0.12.2!

@wolfwood
Copy link
Contributor

wolfwood commented May 8, 2024

Thanks @coolreader18 ! This works in my testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants