-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v0.12.1 has the wrong /dev/
path for enumerate_dev_nodes_blocking
#129
Comments
I traced this back to 50a3369. The commit message is not really correct because in addition to removing the loop and returning |
As far as I know the crate is still active. I'm still a reviewer and have merge perms, but I don't have permissions to publish. If you submit a PR I'll take a look. |
not quite abandoned, i'll merge and release any important PRs. i've recently resumed my open source work after long sabbatical, haven't gotten back to this crate yet |
Good to know |
This reverts commit d0231e3. resolves device pathname regression, issue emberian#129
This reverts commit d0231e3. resolves device pathname regression, issue emberian#129
a bisect using kanata points to d0231e3 as the commit responsible. reverting this commit on top of 0.12.1 allows kanata to retain the previous behavior. I've made PR #147 with the revert. Ideally though would be a 0.12.2 release that cherrypicks the revert on top of 0.12.1. I have a branch with that here: f17826f |
Released 0.12.2! |
Thanks @coolreader18 ! This works in my testing. |
Thanks for the work on this crate!
A user of my project discovered a bug in v0.12.1 where the dev node paths have changed since v0.12.0. It remains an iterator with a single entry as expected, but the single entry has an unexpected path.
jtroo/kanata#455
The text was updated successfully, but these errors were encountered: