Sanitise error throw in production builds

[amk221]

Description

Could Ember Data consider sanitising this error message in production builds?

data/packages/store/addon/-private/system/model/internal-model.ts

Lines 931 to 934 in a3fd90f

	setDirtyAttribute(key, value) {
	if (this.isDeleted()) {
	throw new EmberError(`Attempted to set '${key}' to '${value}' on the deleted record ${this}`);
	}

There is a potential for third party logging services to capture sensitive data via the ${value}.

Although this is possibly not Ember Data's concern, and is instead the responsibility of the developer to fix the actual problem (which would be to not perform the set if the record is deleted in the first place).

Thanks for any insight

[igorT]

@amk221 Thats a very good point. In general having more context in errors is nice, but I completely see the issue here. I think in this case it might be easy to just remove the value part of the message. Do you want to open a PR with the change? @rwjblue do you know if ember has a flag/mode for removing context from error messages?

[amk221]

Would welcome feedback on my PR attempt