New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors : updated version #268

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
5 participants
@tchak
Member

tchak commented May 28, 2012

In this version, we handle validation errors and server errors.
Some ground work is done in order to prepare client side validation support.

For the error handeling part tests are much more complete.

Adapter part is a work in progress (need tests)

@tchak tchak referenced this pull request May 28, 2012

Closed

Errors #181

tchak added some commits Mar 8, 2012

implement `errors` object
* errors are managed by dedicated `errors` object
* adding / removing errors from this object change record state
* bump revision

fix rollback from invalid state

add error state handling

add validate method to record

more tests
@pjlammertyn

This comment has been minimized.

Show comment
Hide comment
@pjlammertyn

pjlammertyn Jun 14, 2012

love to see this in ember data

pjlammertyn commented Jun 14, 2012

love to see this in ember data

@josepjaume

This comment has been minimized.

Show comment
Hide comment
@josepjaume

josepjaume Jun 14, 2012

Wow, I hadn't completely understood your implementation until I tried to achieve something like that myself. It's great, I also found out that transactions don't try to re-commit records when they're invalid.

I really hope this gets merged into ember-data, it's a must-have.

josepjaume commented Jun 14, 2012

Wow, I hadn't completely understood your implementation until I tried to achieve something like that myself. It's great, I also found out that transactions don't try to re-commit records when they're invalid.

I really hope this gets merged into ember-data, it's a must-have.

@wagenet

This comment has been minimized.

Show comment
Hide comment
@wagenet

wagenet Jun 21, 2012

Member

@tchak What's the status of this? I see it doesn't merge cleanly.

Member

wagenet commented Jun 21, 2012

@tchak What's the status of this? I see it doesn't merge cleanly.

@tchak

This comment has been minimized.

Show comment
Hide comment
@tchak

tchak Jun 21, 2012

Member

I talked with @tomdale about it and he did not like it to much I think...
I can rework this but I would like a proper review in order to know what exactly should I change.

One thing that was proposed is to make errors object use Enumerable interface. I will look in to it.
Another question is, should we handle server validation errors, client validation errors and plain server errors on the same interface?

Member

tchak commented Jun 21, 2012

I talked with @tomdale about it and he did not like it to much I think...
I can rework this but I would like a proper review in order to know what exactly should I change.

One thing that was proposed is to make errors object use Enumerable interface. I will look in to it.
Another question is, should we handle server validation errors, client validation errors and plain server errors on the same interface?

@dmathieu dmathieu referenced this pull request Jun 29, 2012

Closed

Pointer on validation #11

@nedcampion

This comment has been minimized.

Show comment
Hide comment
@nedcampion

nedcampion Jul 23, 2012

Realize there's probably more pressing 1.0 Beta work to be done, but I'm real curious about the discussion here. I was just trying out using your errors implementation @tchak with modifications to implement Enumerable . Would love to be of help here however possible.

nedcampion commented Jul 23, 2012

Realize there's probably more pressing 1.0 Beta work to be done, but I'm real curious about the discussion here. I was just trying out using your errors implementation @tchak with modifications to implement Enumerable . Would love to be of help here however possible.

@tchak

This comment has been minimized.

Show comment
Hide comment
@tchak

tchak Aug 12, 2012

Member

Closing in favor of #360

Member

tchak commented Aug 12, 2012

Closing in favor of #360

@tchak tchak closed this Aug 12, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment