Assert that passed array to set a hasMany consists of records #3865
Conversation
| if (!isArrayLike(records)) { return false; } | ||
|
|
||
| return Ember.A(records).every((record) => Model.detectInstance(record) ); | ||
| })()); |
There was a problem hiding this comment.
I am not sure how helpful this assertion message is (considering the use case in #3833). Should I add an explicit check if a DS.PromiseObject is present in the passed array, and if so, warn that the passed array contains the result of a store.findRecord/store.queryRecord which is not supported and how it should be resolved?
There was a problem hiding this comment.
I would keep the existing assertion about an array. Then add an new assertion that says something like all elements of a hasMany relationship must be instances of DS.Model but Ember Data found ${Ember.inspect(badRecord)}.
It may be enough to just test if the first object (if it exists) in the array is a DS.Model and assume that all elements in the array are likely to be of the same type.
There was a problem hiding this comment.
👍 but no reason not to test all of them that i can think of
Assert that passed array to set a hasMany consists of records
|
Thanks @pangratz |
This addresses #3833