Speed up JSONSerializer#applyTransforms #4281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@stefanpenner Do you have time to review this pr? |
|
🚢 |
|
Thanks @balinterdi |
|
@stefanpenner @bmac The pleasure is mine! |
|
sorry, reading for some reason i assumed some benchmarks existed. Are there some? |
|
No, there aren't :), here is (part of the) comment I made in the issue's thread: “So I ended up using if (!(key in data)) which seems to work. The caveat is that I'm not sure whether key in data is any faster than data.hasOwnProperty(key). If somebody knows this for sure, it'd be great if they could confirm/refute this, otherwise I'll try to profile it with some app code.” |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This attempts to fix #2289, see my comments there.