[BUGFIX] ensure all of DS is initialized together #4823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
strange the failure seems to be uglify related... |
|
@stefanpenner the build seems to pass with |
|
More debugging has lead me to believe this line is what uglify is chocking on. https://github.com/ember-cli/loader.js/blob/master/lib/loader/loader.js#L7 I'm not sure why its getting run on the unprocessed loader.js thought. I think I'll lock Ember Data to using |
|
@bmac im not sure what script is running that causes that issue (haven't had a chance to look). My guess is it is pulling in loader.js directly, rather then letting the addon provide it. |
|
Looks like you are right. I've opened a pr with a temporary fix #4824. |
* DS object will always present fully. Today during initialization it remains partially initializers for a period (missing everything from https://github.com/emberjs/data/blob/master/addon/index.js#L91-L154) * this also fixes the (unknown mixin) stuff for all DS classes Although this does force the entire DS namespaces to be initialized immediately. This shouldn’t cause a performance issue, as it the full namespace was always initialized, just in two phases.
stefanpenner
force-pushed
the
fix-namespace
branch
from
9f99405
to
d8f6c4d
Compare
|
@bmac rebased on-top of your fix. |
locks
approved these changes
Feb 26, 2017
tricknotes
added a commit
to tricknotes/ember-data
that referenced
this pull request
Jun 23, 2017
The global build of ember-data has been broken since emberjs#4823. When `ember-data.js is loaded, the following error is occured: ``` Uncaught Error: Could not find module `ember-data/index` imported from `ember-data/initializers/ember-data` ``` A reproduction code is just simple: ``` <!DOCTYPE html> <html> <head> <script src="http://builds.emberjs.com/tags/v2.13.1/ember.prod.js"></script> <script src="http://builds.emberjs.com/tags/v2.14.3/ember-data.js"></script> </head> <body> <h1>Hello, Ember!</h1> </body> </html> ``` The reason of this error is that the broccoli builds the module named "*/index" into `*` for global build. But loader.js couldn't resolve `ember-data/index` as `ember-data`. So the `ember-data/index` module should be to as just `ember-data` to be compatible with NPM package and global.
tricknotes
added a commit
to tricknotes/ember-data
that referenced
this pull request
Jun 23, 2017
The global build of ember-data has been broken since emberjs#4823. When `ember-data.js` is loaded, the following error is occured: ``` Uncaught Error: Could not find module `ember-data/index` imported from `ember-data/initializers/ember-data` ``` A reproduction code is just simple: ``` <!DOCTYPE html> <html> <head> <script src="http://builds.emberjs.com/tags/v2.13.1/ember.prod.js"></script> <script src="http://builds.emberjs.com/tags/v2.14.3/ember-data.js"></script> </head> <body> <h1>Hello, Ember!</h1> </body> </html> ``` The reason of this error is that the broccoli builds the module named "*/index" into `*` for global build. But loader.js couldn't resolve `ember-data/index` as `ember-data`. So the `ember-data/index` module should be to as just `ember-data` to be compatible with NPM package and global.
tricknotes
added a commit
to tricknotes/ember-data
that referenced
this pull request
Jun 23, 2017
The global build of ember-data has been broken since emberjs#4823. When `ember-data.js` is loaded, the following error is occured: ``` Uncaught Error: Could not find module `ember-data/index` imported from `ember-data/initializers/ember-data` ``` A reproduction code is just simple: ``` <!DOCTYPE html> <html> <head> <script src="http://builds.emberjs.com/tags/v2.13.1/ember.prod.js"></script> <script src="http://builds.emberjs.com/tags/v2.14.3/ember-data.js"></script> </head> <body> <h1>Hello, Ember!</h1> </body> </html> ``` The reason of this error is that the broccoli builds the module named "*/index" into `*` for global build. But loader.js couldn't resolve `ember-data/index` as `ember-data`. So the `ember-data/index` module should be to as just `ember-data` to be compatible with NPM package and global.
bmac
pushed a commit
that referenced
this pull request
Jun 24, 2017
The global build of ember-data has been broken since #4823. When `ember-data.js` is loaded, the following error is occured: ``` Uncaught Error: Could not find module `ember-data/index` imported from `ember-data/initializers/ember-data` ``` A reproduction code is just simple: ``` <!DOCTYPE html> <html> <head> <script src="http://builds.emberjs.com/tags/v2.13.1/ember.prod.js"></script> <script src="http://builds.emberjs.com/tags/v2.14.3/ember-data.js"></script> </head> <body> <h1>Hello, Ember!</h1> </body> </html> ``` The reason of this error is that the broccoli builds the module named "*/index" into `*` for global build. But loader.js couldn't resolve `ember-data/index` as `ember-data`. So the `ember-data/index` module should be to as just `ember-data` to be compatible with NPM package and global.
bmac
pushed a commit
that referenced
this pull request
Jul 21, 2017
The global build of ember-data has been broken since #4823. When `ember-data.js` is loaded, the following error is occured: ``` Uncaught Error: Could not find module `ember-data/index` imported from `ember-data/initializers/ember-data` ``` A reproduction code is just simple: ``` <!DOCTYPE html> <html> <head> <script src="http://builds.emberjs.com/tags/v2.13.1/ember.prod.js"></script> <script src="http://builds.emberjs.com/tags/v2.14.3/ember-data.js"></script> </head> <body> <h1>Hello, Ember!</h1> </body> </html> ``` The reason of this error is that the broccoli builds the module named "*/index" into `*` for global build. But loader.js couldn't resolve `ember-data/index` as `ember-data`. So the `ember-data/index` module should be to as just `ember-data` to be compatible with NPM package and global. (cherry picked from commit 17bf1b7)
bmac
pushed a commit
that referenced
this pull request
Jul 21, 2017
The global build of ember-data has been broken since #4823. When `ember-data.js` is loaded, the following error is occured: ``` Uncaught Error: Could not find module `ember-data/index` imported from `ember-data/initializers/ember-data` ``` A reproduction code is just simple: ``` <!DOCTYPE html> <html> <head> <script src="http://builds.emberjs.com/tags/v2.13.1/ember.prod.js"></script> <script src="http://builds.emberjs.com/tags/v2.14.3/ember-data.js"></script> </head> <body> <h1>Hello, Ember!</h1> </body> </html> ``` The reason of this error is that the broccoli builds the module named "*/index" into `*` for global build. But loader.js couldn't resolve `ember-data/index` as `ember-data`. So the `ember-data/index` module should be to as just `ember-data` to be compatible with NPM package and global. (cherry picked from commit 17bf1b7)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although this does force the entire DS namespaces to be initialized immediately. This shouldn’t cause a performance issue, as it the full namespace was always initialized, just in two phases.