Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests for unload + resurrect + remote relationship state #5040

Merged
merged 1 commit into from
Jun 27, 2017

Conversation

stefanpenner
Copy link
Member

No description provided.

Copy link
Member

@hjdivad hjdivad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks right to me

@sly7-7
Copy link
Contributor

sly7-7 commented Jun 27, 2017

@stefanpenner What do you think about adding a test of unloading the child record of the relationship. This would perhaps emphasize the bug found in #4986 ?

@stefanpenner stefanpenner merged commit 9c0cc48 into master Jun 27, 2017
@stefanpenner stefanpenner deleted the unload-reset-remote-rel branch June 27, 2017 14:53
@stefanpenner
Copy link
Member Author

stefanpenner commented Jun 27, 2017

@sly7-7 +1, although I don't have cycles right now to do that, could you maybe give it a whirl?

@sly7-7
Copy link
Contributor

sly7-7 commented Jun 27, 2017

@stefanpenner Actually I think the test is here: #4987

@stefanpenner
Copy link
Member Author

@sly7-7 ah, thanks for pointing that out (sorry so many github issues and PR to keep track of).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants