-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOCS] fix inclusion of docs for deprecation and canary features #6861
Conversation
Asset Size Report for e7ad765 IE11 Builds EmberData has not changed in sizeIf any packages had changed sizes they would be listed here. Changeset
Full Asset Analysis (IE11)
Modern Builds EmberData has not changed in sizeIf any packages had changed sizes they would be listed here. Changeset
Full Asset Analysis (Modern)
Modern Builds (No Rollup) EmberData has not changed in sizeIf any packages had changed sizes they would be listed here. Changeset
Full Asset Analysis (Modern)
|
Performance Report for e7ad765 Relationship Analysis
|
@@ -13,7 +13,9 @@ | |||
"../serializer/addon", | |||
"../store/addon", | |||
"../record-data/addon", | |||
"../debug/addon" | |||
"../debug/addon", | |||
"../private-build-infra/addon", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we adding the private-build infra to yuidocs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need to parse to get the @ember-data/deprecations
guide
/** | ||
@module @ember-data/private-build-infra | ||
*/ | ||
|
||
import { has } from 'require'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we removing this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we're removing it cause we don't document this package directly in the api docs so having yuidocs comments for it just means we accidentally create an empty package we wouldn't otherwise have
The PR title says that we are fixing deprecation and canary features docs, but the non tests changes don't mention deprecations, just the canary-features? |
@igorT the guide for deprecations is a fake package in the file in which we define the current flags for deprecations called |
No description provided.