Fix for uncountable plural names. #940
Conversation
|
@seanrucker Looks great; happy to merge if we can get some tests to ensure we don't get any regressions on this in the future. |
|
@tomdale Simple tests have been added. Followed the same structure used to test person <=> people. What it comes down to is ensuring the serializer.pluralize and serializer.singularize can work with uncountables. |
|
@tomdale Please take a look also at the two other issues fixed by this PR (referenced in the description). |
Fix for race condition. We can't be certain this is the first time the alias has been pluralized. The JSONSerializer may have already pluralized it in the sideLoad -> configureSideloadMappingForType function as defaultSideloadRootForType returns the pluralized form. Test serializer pluralize and singularize with uncountables.
| if (this._didPluralizeAliases) { | ||
| return; | ||
| } else { | ||
| this._didPluralizeAliases = true; |
There was a problem hiding this comment.
This should not happen until the end of the method. If the method encounters an exception while pluralizing aliases, then it would be inaccurate to mark the operation complete. Only after they've been pluralized successfully, should this be marked true
|
Closing as this PR will take care of uncountables as well.#1098 |
The serializer complains if you try to use an uncountable plural name. E.g. "fish" is the same for both singular and plural.
This fix ensures the alias is only added once.
This PR also fixes the following issues:
• #928
• #1003