Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade path #638

Open
yads opened this issue Feb 17, 2021 · 7 comments
Open

Upgrade path #638

yads opened this issue Feb 17, 2021 · 7 comments

Comments

@yads
Copy link

yads commented Feb 17, 2021

I've been working on updating this repository with several updates:

  1. update dependencies including ember-test-helpers and ember-source
  2. add ability to pass down options to setupContext
  3. Add a rudimentary UI to the test page

These are all updates I've made in my fork, specifically the ember-mocha-compat branch https://github.com/yads/ember-mocha/tree/ember-mocha-compat

The first 2 features are handled by #633, once these are merged I can submit another PR for the UI test page.

@gedaiu
Copy link

gedaiu commented Apr 8, 2022

Are there any updates related to this thread? I opened a new pr for mocha 9

#692

@yads
Copy link
Author

yads commented Apr 8, 2022

Not sure, @rwjblue and I came up with a plan where ember-mocha would take a completely different approach than what it has up to this point, but I feel the change is too drastic. I feel like now that Ember has dropped support for IE we can use the Proxy approach that I originally developed, but again I'm not a maintainer and for our Ember project at our company we continue to use my fork.

@gedaiu
Copy link

gedaiu commented Apr 11, 2022

@yads I am all ears... I would love to see this package more maintained...

@yads
Copy link
Author

yads commented Apr 11, 2022

Best I can offer at the moment is my fork :)

@wagenet
Copy link
Member

wagenet commented Jan 27, 2023

@yads would you be happy to take ownership of this?

@yads
Copy link
Author

yads commented Jan 27, 2023

We've recently moved off of mocha and I also tried to update my fork to Ember 4.x and could not get the tests to actually work. Unfortunately I'm no longer in a position to take ownership of this package :(

@wagenet
Copy link
Member

wagenet commented Jan 31, 2023

No problem! Thanks for what you have done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants