Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Use skip_cleanup to fix auto-dist-tag behavior #185

Merged
merged 1 commit into from
Feb 3, 2018

Conversation

Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Feb 3, 2018

@Turbo87 Turbo87 merged commit 2b72812 into emberjs:master Feb 3, 2018
@Turbo87 Turbo87 deleted the skip-cleanup branch February 3, 2018 15:49
@@ -58,6 +58,7 @@ deploy:
email: stefan.penner+ember-cli@gmail.com
api_key:
secure: PQRsq4JcFYPXOqov1jwPw63WnwYYpyKby/2akUjq8PHwwgCDEt34Z8yqQdJogqKmKRjijsiWu+b54fbIpZ6TMvqPL18F8FbCl6e2zoAY55VUmmVkx9wkvuPydTDs2fuPqk6LFvmIMiq+pjEPlSeWg3GpFSkFjfs0WZlO33xMyWw=
skip_cleanup: true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this added, and with using the --skip-cleanup option to ember-try, I think (assuming travis behaves as I am understanding) you'll deploy/publish the package.json as it was when switched to the last scenario run. Right now this is ember-default which should have no changes, but seems very coincidental.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants