Try to recreate problem with properties in unit tests #431
Conversation
brunoocasali
changed the title
| @@ -39,7 +39,13 @@ describe('setupRenderingTest', function() { | |||
| expect(this.element.textContent.trim()).to.equal('Pretty Color: green'); | |||
| }); | |||
|
|
|||
| it('renders a second time without', async function() { | |||
| it('renders with new color with same property', async function() { | |||
| this.set('name', 'red'); | |||
There was a problem hiding this comment.
@brunoocasali what happens if you change this line to this.name = 'red'? I'm investigating a ton of failures in our app since bumping to ember-source@3.13 and am curious if this is the same issue.
There was a problem hiding this comment.
@efx at my company app using the way you told me worked for some of failing specs, but for some reason in others it doesn't. But I can't reproduce this remaining failing specs in the demo project.
From my company app I have this failing examples: https://gist.github.com/brunoocasali/a50170c59a35e75e7bcaaf078f4cff99
Breaks the last of specs and the first...
There was a problem hiding this comment.
Interesting; thanks for testing that @brunoocasali. I copied your work here and can reproduce the same failure when using this.set('name', 'red') versus this.name = 'red'. I'll raise this in the testing discord to see if anyone has experienced this.
There was a problem hiding this comment.
Awesome! :)
Do you have any ideas about where is the problem origin? Like another lib for example?
There was a problem hiding this comment.
I did some initial bisecting and saw this ember-source PR: emberjs/ember.js#18314 but am not familiar enough to say whether or not it is related. That said, downgrading ember-source does make the tests pass: https://github.com/emberjs/ember-mocha/compare/master...efx:failing-setter-test-downgrade-ember?expand=1
So it is something introduced in 3.13.x
ghost
mentioned this pull request
ghost
mentioned this pull request
Related with #430