[DOC] Mark replaceWith and replaceRoute as deprecated
#19775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Before merging this change, it would be good to see some of the issues linked here addressed #19609. Currently, on a route |
|
I'm not really following. The linked RFC has already been merged and implemented a while ago. Those methods are already deprecated. This just adds the |
locks
reviewed
Oct 10, 2021
| @@ -162,7 +162,7 @@ ControllerMixin.reopen({ | |||
| @method transitionToRoute | |||
| @return {Transition} the transition object associated with this | |||
| attempted transition | |||
| @deprecated Use transitionTo from the Router service instead. | |||
| @deprecated Use `transitionTo` from the Router service instead. | |||
There was a problem hiding this comment.
I'm not sure the backticks here actually work, we have to confirm.
There was a problem hiding this comment.
Where do we show these messages? It seems they are not displayed in the docs. Do you want me to remove the backticks?
bertdeblock
force-pushed
the
mark-replaceWith-and-replaceRoute-as-deprecated
branch
from
c850386
to
50359b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to emberjs/rfcs#674.