-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
provide debug utilities for inspector via event communication #20580
base: main
Are you sure you want to change the base?
Conversation
maybe @chancancode ? |
c7e2bab
to
592e9cf
Compare
bb68625
to
208881f
Compare
208881f
to
9307366
Compare
We now need this to proceed with emberjs/rfcs#1015 For the VM side of this, glimmerjs/glimmer-vm#1489, benchmarks are running, so we'll know if this is safe. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this implementation is good for now, but we'll need to change things later, because I think we want ember-source to push panels into the inspector somehow.
needs some planning there, but it'd be great if ember-source's part of the inspector could be tested within ember-source, and than the inspector slurps those up (automatic updates depending on ember-source version!)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think pushing panels is not needed. more important would be to push a ember_debug directly from ember.js instead of having inspectors ember_debug try to support multiple versions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well the thinking here is that because ember.js is has more people working on it, it could be updated more easily than the inspector -- and then the inspector also doesn't need to maintain compatibility with everything going forward -- as it would be provided by ember-source
we should probs move to talking about this on the discord though -- lots of details to work through
Are these things not already accessible via their existing private import paths? |
Not with ember static source enabled. Then it's not accessible. |
Biggest issue is the boot load event. And the whole ember source needs to be loaded before inspector can access it. (With AMD) There have been multiple issues around that in the past. |
E.g. emberjs/ember-inspector#2051 As an example |
this would allow inspector to communicate with emberjs without relying on any globals like the define, require functions and without the barrel file.
it would be required for inspector to provide more functionality when using vite or also when building with embroider webpack and staticEmberSources=true
would also like to glimmerjs/glimmer-vm#1489
as part of this
emberjs/ember-inspector#2554