Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CHANGELOG.md – add Upgrade the Glimmer VM from 0.84.3 to 0.85.13 to release notes of v5.6.0 #20646

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

johanrd
Copy link
Contributor

@johanrd johanrd commented Feb 10, 2024

See v5.5.0...v5.6.0

I experienced some weird regressions that could not have come from the other changes in the logs, so it may be relevant for others to have this pointed out as well.

….13` to release v5.6.0

See emberjs/ember.js@v5.5.0...v5.6.0

I experienced some weird regressions that could not have come from the other changes in the logs, so it may be relevant for others to have this pointed out as well.
@NullVoxPopuli
Copy link
Contributor

NullVoxPopuli commented Feb 10, 2024

same -- in particular, shadow-dom support has regressed for me
related: #20644

@boris-petrov
Copy link
Contributor

And the regression with the bundle size probably comes from there.

@kategengler kategengler merged commit 4405510 into emberjs:main Mar 4, 2024
20 checks passed
@kategengler
Copy link
Member

Thank you!

@johanrd
Copy link
Contributor Author

johanrd commented Mar 8, 2024

@kategengler great, thanks, yet, maybe I committed to the wrong file, as the release notes of 5.6.0 still does not include the line about glimmer-vm?

@kategengler
Copy link
Member

@johanrd You got the correct file.

There's two different things here:

The CHANGELOG.md file shipped with 5.6.0 will never change -- it has been released and we wouldn't backport and release just for a changelog change.

Release notes on GitHub do not source from CHANGELOG.md but are manually created at release time by my pasting in the changelog text. I'll update it now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants