Cleanup warning noise from eslint #20684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We inherit several default rules at the "warn" level. IMO it's useless to leave rules at "warn", because people just ignore them and live with an increasing amount of noise. As evidence I cite the 716 warnings that one must currently scroll through to find an actual lint failure. This change turns unused-vars into errors, while enabling underscore-based exceptions that follow typescript's own defaults for its internal unused-vars rule. And it disables no-explicit-any and no-non-null-assertion. These features are in the language for a reason. Idiomatic javascript that gains types after-the-fact needs these features, which is why we need them all over the place. If somebody else thinks these rules are good, I'm all in favor of enabling them **as errors** so they actually get followed, but then you've gotta do the project to refactor all the types to not need them so much.
NullVoxPopuli
approved these changes
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We inherit several default rules at the "warn" level. IMO it's useless to leave rules at "warn", because people just ignore them and live with an increasing amount of noise.
As evidence I cite the 716 warnings that one must currently scroll through to find an actual lint failure.
This change turns unused-vars into errors, while enabling underscore-based exceptions that follow typescript's own defaults for its internal unused-vars rule.
And it disables no-explicit-any and no-non-null-assertion. These features are in the language for a reason. Idiomatic javascript that gains types after-the-fact needs these features, which is why we need them all over the place. If somebody else thinks these rules are good, I'm all in favor of enabling them as errors so they actually get followed, but then you've gotta do the project to refactor all the types to not need them so much.