Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate import Ember from 'ember' #20686

Merged
merged 2 commits into from
May 10, 2024

Conversation

NullVoxPopuli
Copy link
Contributor

@NullVoxPopuli NullVoxPopuli commented Apr 22, 2024

@NullVoxPopuli NullVoxPopuli force-pushed the deprecate-import-ember-from-ember branch 2 times, most recently from 17a6f91 to b5eaa95 Compare April 29, 2024 21:57
@NullVoxPopuli NullVoxPopuli force-pushed the deprecate-import-ember-from-ember branch from 7a95c95 to 70d0ca8 Compare May 2, 2024 15:10
@NullVoxPopuli NullVoxPopuli marked this pull request as ready for review May 2, 2024 15:17
@NullVoxPopuli NullVoxPopuli force-pushed the deprecate-import-ember-from-ember branch from 703a25b to 3e46fe1 Compare May 9, 2024 21:10
@kategengler kategengler requested a review from ef4 May 9, 2024 23:43
@NullVoxPopuli NullVoxPopuli force-pushed the deprecate-import-ember-from-ember branch from 9cfcb7b to b00fbb3 Compare May 10, 2024 02:29
Copy link
Member

@kategengler kategengler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like @ef4 to take a look too

@ef4
Copy link
Contributor

ef4 commented May 10, 2024

High priority places that currently hit the deprecation in a stock app:

  • ember-cli-app-version
  • ember-resolver
  • @glimmer/component
  • ember-inspector

Chasing all these down and getting them fixed and released is going to be important to make this practical as an until 6.0 deprecation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants