Pre-build-reform cleanups #20688
Merged
Pre-build-reform cleanups #20688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These unused mutable bindings produce worse build output when building Ember with rollup. And they're wordier anyway.
Depending on what build environment the test suite is using, class names could get mangled (because they're getting merged into a shared module namespace for example). This makes the tests not care.
This is arguably just cleaner style, but the reason I care in particular is that there is a bug in babel such that under certain settings this emits:
```js
class Registry {
// ...
set
constructor() {
// ...
}
}
```
which is a syntax error because it looks like your constructor is a setter.
With `declare`, typescript completely removes the pointless runtime field initializer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are three small changes extracted from #20675 for ease of review. Each commit is self-contained with its own description.