-
-
Notifications
You must be signed in to change notification settings - Fork 875
Use fenced code metadata to annotate both file location and language #30
Comments
Should I update my current PRs to the guide, or wait until this new change has been made? |
I'd update current PRs and Issue this can be a blocker for merging those |
@trek Anyone covering the new custom highlighter? If not, I can take a stab at it, seems reasonable. We're going to really need to detect 2 different file types, js and hbs, right? Or are there css and html fences needed too? |
@danmcclain - Its all yours :) |
@rwjblue Can you confirm file types in guides? I'll try to get something in place this weekend |
@danmcclain |
And considering the CLI portion, |
For the JS files, is it going to be in this format? ```app/components/my-component.js
// javascript goes here NVM...just read the commit. Updating now. |
From the common mark spec:
Where we annotate the code's language
We can annotate filename and extension:
We have a custom highlighter that outputs particular markup/styles for specific languages.
A PR that addresses this Issue will:
@danmcclain has a sample markup/design
The text was updated successfully, but these errors were encountered: