-
-
Notifications
You must be signed in to change notification settings - Fork 875
Conversation
#35 is merged now |
I think, yes, the previews expire now :( |
Ok, will redo. |
There is larger issues that if jsbins need updates, we need to use a shared account. In the core team meeting just now we decided moving examples to cli style is more important than live code samples. We're going to just remove jsbins until we figure out how to better have live samples. |
So....remove the JSbins for now? |
Yeah, we're just going to nuke them. Possibly comment them out so we know where to put them back in later? |
Ok sounds good to me! |
Commented out JSbins |
```app/route/application.js | ||
import currentDate from './helpers/current-date.js'; | ||
|
||
Ember.Handlebars.registerBoundHelper('current-date', currentDate); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not needed.
What's needed for merging? |
Can you squash this into a single commit? |
@trek the person who is accepting the pull request you mean? |
@nicolechung I think he meant you. I also usually squash my own PR's before they get merged. |
@joostdevries how do you do this? (forgive me if this is a stupid question). I only know how to squash when merging. I've merged the master a few times into this feature (to keep up). If I do a git rebase -i master is that totally going to rewrite history for other people? |
@nicolechung I hope these are helpful:
If you're unsure I can help you directly later today. |
When I've already merged master into my dev branch, I usually do a merge-squash:
|
Thanks @locks and @joostdevries I'll get on this in the afternoon... |
@trek seems ready |
Cookbooks to ember-cli.
JSbins: I was using the free (non-account) version to create the bins...is this going to be a problem? Do the previews expire?