Skip to content
This repository has been archived by the owner on May 26, 2019. It is now read-only.

Update: Ember cookbook to cli #25

Merged
merged 1 commit into from
Mar 20, 2015
Merged

Update: Ember cookbook to cli #25

merged 1 commit into from
Mar 20, 2015

Conversation

nicolechung
Copy link
Contributor

Cookbooks to ember-cli.

JSbins: I was using the free (non-account) version to create the bins...is this going to be a problem? Do the previews expire?

@nicolechung nicolechung mentioned this pull request Mar 3, 2015
19 tasks
@nicolechung nicolechung changed the title Feature/cookbooks to cli Update: Ember cookbook to cli Mar 4, 2015
@nicolechung
Copy link
Contributor Author

@trek updated to reflect #30 but can't check my work visually until #35 is merged.

@rwjblue
Copy link
Member

rwjblue commented Mar 8, 2015

#35 is merged now

@trek
Copy link
Member

trek commented Mar 13, 2015

I think, yes, the previews expire now :(

@nicolechung
Copy link
Contributor Author

Ok, will redo.

@trek
Copy link
Member

trek commented Mar 13, 2015

There is larger issues that if jsbins need updates, we need to use a shared account. In the core team meeting just now we decided moving examples to cli style is more important than live code samples. We're going to just remove jsbins until we figure out how to better have live samples.

@nicolechung
Copy link
Contributor Author

So....remove the JSbins for now?

@trek
Copy link
Member

trek commented Mar 13, 2015

Yeah, we're just going to nuke them. Possibly comment them out so we know where to put them back in later?

@nicolechung
Copy link
Contributor Author

Ok sounds good to me!

@nicolechung
Copy link
Contributor Author

Commented out JSbins

```app/route/application.js
import currentDate from './helpers/current-date.js';

Ember.Handlebars.registerBoundHelper('current-date', currentDate);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not needed.

@locks
Copy link
Contributor

locks commented Mar 20, 2015

What's needed for merging?

@trek
Copy link
Member

trek commented Mar 20, 2015

Can you squash this into a single commit?

@nicolechung
Copy link
Contributor Author

@trek the person who is accepting the pull request you mean?

@joostdevries
Copy link
Contributor

@nicolechung I think he meant you. I also usually squash my own PR's before they get merged.

@nicolechung
Copy link
Contributor Author

@joostdevries how do you do this? (forgive me if this is a stupid question). I only know how to squash when merging.

I've merged the master a few times into this feature (to keep up). If I do a git rebase -i master is that totally going to rewrite history for other people?

@locks
Copy link
Contributor

locks commented Mar 20, 2015

@joostdevries
Copy link
Contributor

When I've already merged master into my dev branch, I usually do a merge-squash:

git checkout cookbooks-to-cli
git branch -m cookbooks-to-cli-old
git checkout master
git checkout -b cookbooks-to-cli
git merge --squash cookbooks-to-cli-old
git commit

@nicolechung
Copy link
Contributor Author

Thanks @locks and @joostdevries I'll get on this in the afternoon...

@locks
Copy link
Contributor

locks commented Mar 20, 2015

@trek seems ready

trek added a commit that referenced this pull request Mar 20, 2015
@trek trek merged commit abbb003 into emberjs:master Mar 20, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants